feat: add generatorLibrary options and allow faker to select #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ TODO
|
MH4GF
force-pushed
the
add-generator-library-option
branch
from
eec74c1 to
4c19722
Compare
ardeois
reviewed
Sep 27, 2022
Because faker almost completed migrating to TypeScript so that DefinitelyTyped no longer needs to maintain its external [@types/faker](https://www.npmjs.com/package/@types/faker) package. ref: https://fakerjs.dev/about/announcements/2022-01-14.html
As shown in the following code, the result changes even if the seed is added:
```
> const { faker } = require("@faker-js/faker")
undefined
> faker.seed(0)
0
> const a = faker.date.past().toISOString()
undefined
> a
'2022-03-08T21:45:15.158Z'
> faker.seed(0)
0
> const b = faker.date.past().toISOString()
undefined
> b
'2022-03-08T21:45:30.411Z'
> a === b
false
```
This is because the default refDate passed in the second argument of faker.date.past() is now, so we can fix it at a specific date.
ref: faker-js/faker#859
MH4GF
commented
Sep 28, 2022
| @@ -36,7 +37,6 @@ | |||
| "devDependencies": { | |||
| "@auto-it/conventional-commits": "^10.33.0", | |||
| "@graphql-codegen/testing": "^1.17.7", | |||
| "@types/faker": "^5.5.9", | |||
There was a problem hiding this comment.
It was probably left in there because it was forgotten to erase it, but now the type definitions have been imported into the repository and are no longer needed.
5a8cd1b
| ? `faker.date.past().toISOString(1, new Date(2022, 0))` | ||
| : `'${faker.date.past(1, new Date(2022, 0)).toISOString()}'`; | ||
| seed = (seed: number) => faker.seed(seed); | ||
| } |
There was a problem hiding this comment.
The compatibility of the execution results of each function is checked here:
#92 (comment)
|
@MH4GF all good, merging and closing the issue |
This was referenced Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #90, related #92
What
Add a new option
generateLibraryto make faker available in addition to the existing casual.Context
casual dependents on the node API(e.g. fs) and cannot be made to work in the browser.
ref: #90
Additional Information
To simplify the code, we also added a class that returns the mock value generated by the library.